froll manual improvements for vectorized input#7297
Merged
jangorecki merged 19 commits intomasterfrom Sep 9, 2025
Merged
Conversation
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7297 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 83 83
Lines 15780 15780
=======================================
Hits 15635 15635
Misses 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit cff2b6d Download link for the artifact containing the test results: ↓ atime-results.zip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I intentionally removed "vector" to keep description of the arguments simpler, and then at its end, when non-vectorized input is more easily described, I mention about possibility to vectorize.
I believe it is not completely ideal but at least improvement towards clarity.
closes #7296
diff: frolladapt2025...froll-nman
This work was supported by the Medical Research Council, UK [grant number 1573].