Skip to content

froll manual improvements for vectorized input#7297

Merged
jangorecki merged 19 commits intomasterfrom
froll-nman
Sep 9, 2025
Merged

froll manual improvements for vectorized input#7297
jangorecki merged 19 commits intomasterfrom
froll-nman

Conversation

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Sep 9, 2025

I intentionally removed "vector" to keep description of the arguments simpler, and then at its end, when non-vectorized input is more easily described, I mention about possibility to vectorize.
I believe it is not completely ideal but at least improvement towards clarity.

closes #7296

diff: frolladapt2025...froll-nman

This work was supported by the Medical Research Council, UK [grant number 1573].

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (9b421c8) to head (2e9ae4e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7297   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          83       83           
  Lines       15780    15780           
=======================================
  Hits        15635    15635           
  Misses        145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

  • HEAD=froll-nman stopped early for DT[by,verbose=TRUE] improved in #6296
  • HEAD=froll-nman stopped early for DT[,.SD] improved in #4501
    Comparison Plot

Generated via commit cff2b6d

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 52 seconds
Installing different package versions 10 minutes and 29 seconds
Running and plotting the test cases 2 minutes and 48 seconds

@jangorecki jangorecki added this to the 1.18.0 milestone Sep 9, 2025
@jangorecki jangorecki merged commit 1a93d1f into master Sep 9, 2025
11 checks passed
@jangorecki jangorecki deleted the froll-nman branch September 9, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve froll vectorized input manual description

2 participants