Skip to content

add performance test for sort_by.data.table #7267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tdhock wants to merge 1 commit into from
Closed

add performance test for sort_by.data.table #7267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,25 @@ test.list <- atime::atime_test_list(
paste0('useDynLib(', new.Package_))
},

# New sort_by.data.table method implemented https://github.com/Rdatatable/data.table/pull/6679
# Test case adapted from https://github.com/Rdatatable/data.table/issues/6662#issue-2737165196
"sort_by.data.table created in #6679" = atime::atime_test(
seconds.limit=0.1,
Fast="ee44ef45814115003d1499284227af6f5e487ad3",# Last commit in the PR (https://github.com/Rdatatable/data.table/pull/6679/commits) that implemented the new feature.
Slow="4a2474b59637aad9e032b1eaee6e9bdcfc4df949",# Parent of the first commit (https://github.com/Rdatatable/data.table/commit/60828522cb1dbf696ce32a7323464d9d8870b9f6) in the PR (https://github.com/Rdatatable/data.table/pull/6679/commits) that implemented the new feature.
expr={
sort_by_lang <- str2lang("data.table:::sort_by.data.table")
tryCatch(eval(sort_by_lang), error=function(e){
sort_by_lang <<- str2lang("sort_by.data.frame")
})
my_call <- substitute(FUN(DT, ~ x + y), list(FUN=sort_by_lang))
eval(my_call)
},
setup={
set.seed(1234)
DT <- data.table(x=runif(N),y=runif(N))
}),

# Constant overhead improvement https://github.com/Rdatatable/data.table/pull/6925
# Test case adapted from https://github.com/Rdatatable/data.table/pull/7022#discussion_r2107900643
"fread disk overhead improved in #6925" = atime::atime_test(
Expand Down
Loading