tests: avoid invalid UTF-8 warning #7209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under options(encoding="UTF-8"), writeLines() always tries to perform text conversion. Giving it bytes that aren't valid in the current encoding results in warnings. Avoid the warning by explicitly opening a file connection with encoding="" (no conversion).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7209 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 81 81
Lines 15215 15215
=======================================
Hits 15029 15029
Misses 186 186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inst/tests/tests.Rraw
Outdated
| # regression test for hexdigits subscript overrun (uint8_t wraps over 255, unsigned overflow is well defined in c) | ||
| f = tempfile() | ||
| writeLines(c('a', rep('0x1.ffffp0', 10000L), '0x1.ff\x9fp0', rep('0x1.ffffp0', 20000L)), f) | ||
| ff = file(f, encoding = "") |
Member
There was a problem hiding this comment.
might as well put the whole thing in local() to on.exit() closing & deleting.
Also a comment pointing to this PR would be good for posterity sake.
MichaelChirico
approved these changes
Jul 24, 2025
Co-Authored-By: Michael Chirico <michaelchirico4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that my test case from #7138 (comment) causes a warning, but only if run under
test.data.table(). The underlying cause isoptions(encoding = "UTF-8")being in effect for the duration of the test:data.table/R/test.data.table.R
Lines 92 to 94 in 63339e1
We need to write a byte with the most significant bit set, and
file(encoding = getOption('encoding'))opened bywriteLines()trying to convert that byte from the current encoding to UTF-8 doesn't help. Avoid the warning by explicitly opening a file connection withencoding=""(no conversion) and marking the payload line as"bytes".