Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7198 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 81 81
Lines 15212 15212
=======================================
Hits 15026 15026
Misses 186 186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Generated via commit 06805a5 Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
Hi @badasahog I would prefer to focus on the new segfault #7183. We'll have to revert the breaking change if the new issue can't be fixed. |
|
I think that's in a separate part of the code? Also, do you have a minimal example I could use to recreate the segfault? All tests cleared on my end. |
|
Did you test under ASAN? The issue is shown clearly in the logs linked in the issue. Let's please continue the discussion there. |
|
now that that's done, is this ready to go? |
…e/data.table into ReformattingAndCleanup
|
are there any other files that don't have outstanding PRs? |

As far as I can tell these files haven't been touched in a while, so there shouldn't be any major conflicts.
Only one change was functional (switching to memset). Other than that, everything here is purely cosmetic.