Avoid "global" options() in more test suites#7111
Merged
ben-schwen merged 3 commits intomasterfrom Jul 15, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7111 +/- ##
=========================================
Coverage ? 98.50%
=========================================
Files ? 79
Lines ? 14754
Branches ? 0
=========================================
Hits ? 14533
Misses ? 221
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #5845 to use
test(options=more frequently.local()blocks rather than several or dozens of consecutive identicaloptions=provisions. This cleans up the code a fair amount. Basically, the end state here is thatoptions()should only be called in a test suite (1) underoptions=or (2) inside alocal()call. We can enforce this with {lintr} eventually.