fread: consider quoted na.strings in text columns#7068
fread: consider quoted na.strings in text columns#7068MichaelChirico merged 4 commits intomasterfrom
na.strings in text columns#7068Conversation
Previously, Field() only called end_NA_string() for non-quoted fields, making it impossible to set na.strings='""' and parse empty quoted strings as missing. Fixes: #6974
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7068 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 79 79
Lines 14759 14761 +2
=======================================
+ Hits 14538 14540 +2
Misses 221 221 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 86b1517 Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
I haven't quite wrapped my head around this, but it seems like it's preferable not to need the quotes inside E.g. in this file: All of the string fields are clearly (to us humans) quoted, therefore the "contents" on the first line are Similarly for OP's example: I would expect I think there are a few related issues, e.g. #2586? |
|
The documented behaviour for
Currently, It seems that according to the current rules, a quoted empty string should be marked as missing using |
|
Thanks... yea, I guess we can imagine a world where we only attempt to disambiguate `` from |

Previously,
Field()only calledend_NA_string()for non-quoted fields, making it impossible to setna.strings='""'and parse empty quoted strings as missing.Fixes: #6974