Run more GHA on pull requests targeting any branch#6553
Merged
MichaelChirico merged 2 commits intomasterfrom Sep 30, 2024
Merged
Run more GHA on pull requests targeting any branch#6553MichaelChirico merged 2 commits intomasterfrom
MichaelChirico merged 2 commits intomasterfrom
Conversation
MichaelChirico
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6553 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 79 79
Lines 14448 14448
=======================================
Hits 14249 14249
Misses 199 199 ☔ View full report in Codecov by Sentry. |
Anirban166
reviewed
Sep 30, 2024
Member
Anirban166
left a comment
Anirban166
left a comment
There was a problem hiding this comment.
Right, the * wildcard is redundant. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in #6432; stacked PRs will still benefit from seeing coverage reports up-stack.
Get consistent with the rest of the GHA for
pull_request:trigger while we're here. cc @Anirban166, I didn't check to be 100% surebranches: '*'is the same as just not filtering by branch, but I think it is. Note that #6432 is running the atime tests.