Skip to content

Restore covr#6540

Merged
MichaelChirico merged 9 commits intomasterfrom
revert-6122-disable-covr
Sep 26, 2024
Merged

Restore covr#6540
MichaelChirico merged 9 commits intomasterfrom
revert-6122-disable-covr

Conversation

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Sep 25, 2024

Closes #6479.

First tried reverting the old GHA, but I think there was a cacheing issue there as we continued to segfault even with old R. Therefore I cribbed the code-coverage GHA from dplyr which is structurally a bit different. With that change our codecov passes again, once I pinned the R version to <4.4.

I also generated+added a CODECOV_TOKEN under our repo secrets.

@MichaelChirico
Copy link
Member Author

OK, we have covr() working 🎉 there's still some stuff to iron out about tokens & communicating to codecov, hopefully that part's easier:

Error: Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

@MichaelChirico
Copy link
Member Author

(side note: added @tdhock @jangorecki and @ben-schwen as admins in the codecov.io "project" for Rdatatable)

@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (6f3fc8d) to head (ad18c93).
Report is 402 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6540      +/-   ##
==========================================
- Coverage   97.51%   97.02%   -0.49%     
==========================================
  Files          80       81       +1     
  Lines       14979    14708     -271     
==========================================
- Hits        14607    14271     -336     
- Misses        372      437      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member Author

Looks like we've lost 0.44% coverage since the last upload 6f3fc8d :)

@tdhock
Copy link
Member

tdhock commented Sep 25, 2024

not bad thanks

@MichaelChirico MichaelChirico merged commit 11a44bd into master Sep 26, 2024
@MichaelChirico MichaelChirico deleted the revert-6122-disable-covr branch September 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable covr

2 participants