Skip to content

Only run atime tests on non-fork branches#6481

Merged
tdhock merged 1 commit intomasterfrom
atime-run-local
Sep 6, 2024
Merged

Only run atime tests on non-fork branches#6481
tdhock merged 1 commit intomasterfrom
atime-run-local

Conversation

@MichaelChirico
Copy link
Member

Observed in #4883 -- PRs originating from a fork will fail:

https://github.com/Rdatatable/data.table/actions/runs/10734222605/job/29768987281?pr=4883

Run git switch "${GITHUB_BASE_REF}"
# Previous HEAD position was 34257529 Merge 578abecb6b580da7fed2c80b4343c4d1a6b8717e into b56682218696ea6970e189e5f55cf0102a516121
# Switched to a new branch 'master'
# branch 'master' set up to track 'origin/master'.
# fatal: invalid reference: named_lapply
# Error: Process completed with exit code 128.

The alternative is to try and get this running on fork-originated PRs, I'm not sure it's needed.

@MichaelChirico MichaelChirico added ci atime Requests related to adding/improving/monitoring performance regression tests via atime. labels Sep 6, 2024
@tdhock
Copy link
Member

tdhock commented Sep 6, 2024

excellent idea, thanks, I didn't know you could do that.

@tdhock tdhock merged commit 79b3840 into master Sep 6, 2024
@MichaelChirico MichaelChirico deleted the atime-run-local branch September 6, 2024 14:39
@Anirban166
Copy link
Member

Seems reasonable, but I think we should add a note directly in .github/workflows/performance-tests.yml (or .ci/atime/tests.R if appropriate enough) to remove the condition for people who intend to test changes in their fork (GHA will get skipped otherwise).

@tdhock
Copy link
Member

tdhock commented Sep 10, 2024

I dont think it is possible (permissions) for this to run on forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

atime Requests related to adding/improving/monitoring performance regression tests via atime. ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants