Use ngettext() for some plural messages in R#6476
Merged
MichaelChirico merged 7 commits intomasterfrom Sep 11, 2024
Merged
Conversation
MichaelChirico
added
the
translation
|
Generated via commit bd8b1f9 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 3 minutes and 29 seconds Time taken to run |
MichaelChirico
requested review from
rffontenelle
and removed request for
tdhock
tdhock
approved these changes
Sep 11, 2024
Member
tdhock
left a comment
tdhock
left a comment
There was a problem hiding this comment.
looks fine to me. I didn't know about ngettext, that is neat!
Member
Author
It's crucial for generic translation -- once you leave romance languages + CJK pluralization gets pretty wild: https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6194. C-side messages were in #6475.
@rffontenelle for one case, I can't tell what variable determines whether this should be plural or not. I'm tempted to just leave it be, translators can just do anything? WDYT?
data.table/R/foverlaps.R
Line 157 in 97980d9