Consistently error when allocation request fails#6271
Merged
MichaelChirico merged 16 commits intomasterfrom Jul 16, 2024
Merged
Consistently error when allocation request fails#6271MichaelChirico merged 16 commits intomasterfrom
MichaelChirico merged 16 commits intomasterfrom
Conversation
|
Generated via commit 1cb8e1a Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 12 minutes and 31 seconds Time taken to run |
tdhock
approved these changes
Jul 16, 2024
Member
tdhock
left a comment
There was a problem hiding this comment.
this looks good to me. Thanks!
maybe add a NEWS item about the linter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of #1115
Also
free()all objects when we allocate several consecutivelyCalloc(), which is very explicitly advertised not to need this checking: https://cran.r-project.org/doc/manuals/r-release/R-exts.html#User_002dcontrolled-memoryTODO:
free(); free();instead ofif (.) free(.), for conciseness