Skip to content

Comments

added output= to new test 1035.013#4983

Merged
mattdowle merged 1 commit intomasterfrom
fix4455-followup
May 9, 2021
Merged

added output= to new test 1035.013#4983
mattdowle merged 1 commit intomasterfrom
fix4455-followup

Conversation

@mattdowle
Copy link
Member

Follow up to #4723
One of its new tests had this output from test.data.table() :

Running test id 1035.013      Duplicate column names found in molten data.table. Setting unique names using 'make.names'

So added output= to the test to capture and test that cat() happening. Other tests have output= for the same cat() too.
The cat() itself seems to be long-standing (maybe it should be prefixed with if (verbose)).

@mattdowle mattdowle added this to the 1.14.1 milestone May 9, 2021
@codecov
Copy link

codecov bot commented May 9, 2021

Codecov Report

Merging #4983 (3ba676a) into master (f5c6526) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4983   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          73       73           
  Lines       14612    14612           
=======================================
  Hits        14532    14532           
  Misses         80       80           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c6526...3ba676a. Read the comment docs.

@mattdowle mattdowle merged commit 357f69e into master May 9, 2021
@mattdowle mattdowle deleted the fix4455-followup branch May 9, 2021 09:59
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants