Skip to content

install less in travis #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattdowle merged 1 commit into from
Jan 10, 2020
Merged

install less in travis #4168

mattdowle merged 1 commit into from
Jan 10, 2020

Conversation

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Jan 10, 2020

@MichaelChirico
Copy link
Member

MichaelChirico commented Jan 10, 2020

LGTM! Forgot about when covr broke & we did this

@jangorecki
Copy link
Member Author

jangorecki commented Jan 10, 2020 •
edited
Loading

stringi issue is here: gagolews/stringi#366

Looks like a Dependency hell example :)
It would probably be best to clarify why stringi is required for R travis-ci in https://travis-ci.community/c/languages/r but this forum won't let you to sign up using email but requires you to grant auth to your private github info.

@jangorecki jangorecki added the ci label Jan 10, 2020
@MichaelChirico
Copy link
Member

MichaelChirico commented Jan 10, 2020

Luckily I don't mind :)

https://travis-ci.community/t/why-is-stringi-required-for-travis-ci/6800?u=michaelchirico

@mattdowle
Copy link
Member

mattdowle commented Jan 10, 2020 •
edited
Loading

This looks good to remove devtools from our travis.yml. So merging PR. But it seems the stringi dependency is still there somehow and this PR isn't passing, iiuc. Where's the remaining dependency on stringi then: covr?

@mattdowle mattdowle merged commit 793f854 into master Jan 10, 2020
@mattdowle mattdowle deleted the travis-less branch January 10, 2020 20:40
@MichaelChirico
Copy link
Member

MichaelChirico commented Jan 10, 2020 •
edited
Loading

yes, covr->rex->stringr->stringi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jangorecki @MichaelChirico @mattdowle