Skip to content

Conversation

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Feb 4, 2019

closes #3335
resolves one file in the list in #3301
also adds support for long vectors

@mattdowle mattdowle mentioned this pull request Feb 4, 2019
12 tasks
@jangorecki jangorecki added this to the 1.12.2 milestone Feb 4, 2019
@mattdowle mattdowle changed the title fix shift neg n for double type, closes #3335, also removes DATAPTR #… fix shift neg n for double type Feb 8, 2019
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #3348 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
+ Coverage   94.72%   94.73%   +<.01%     
==========================================
  Files          65       65              
  Lines       12156    12133      -23     
==========================================
- Hits        11515    11494      -21     
+ Misses        641      639       -2
Impacted Files Coverage Δ
src/shift.c 98.96% <100%> (-0.2%) ⬇️
src/gsumm.c 90.9% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079968b...9ad9e19. Read the comment docs.

@mattdowle mattdowle merged commit dd1039c into master Feb 8, 2019
@mattdowle mattdowle deleted the shift-neg-n-fix branch February 8, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shift negative n unexpected results for double

2 participants