Skip to content

Missing both i and j#3250

Merged
mattdowle merged 6 commits intomasterfrom
missingij
Jan 2, 2019
Merged

Missing both i and j#3250
mattdowle merged 6 commits intomasterfrom
missingij

Conversation

@mattdowle
Copy link
Member

Minor fixes to pass several revdeps in #3233
New stops downgraded to warning (a few packages hit them in their examples, where warnings pass.)
News item clarified that user-defined and inherited attributes are now retained, closes #995. This was solved now that DT[...] calls CsubsetDT which calls copyMostAttributes at C level.

@mattdowle mattdowle added this to the 1.12.0 milestone Jan 2, 2019
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #3250 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3250      +/-   ##
==========================================
+ Coverage   94.65%   94.65%   +<.01%     
==========================================
  Files          65       65              
  Lines       12099    12103       +4     
==========================================
+ Hits        11452    11456       +4     
  Misses        647      647
Impacted Files Coverage Δ
src/subset.c 100% <100%> (ø) ⬆️
R/data.table.R 95.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb3f60...f92924b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #3250 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3250      +/-   ##
==========================================
+ Coverage   94.65%   94.65%   +<.01%     
==========================================
  Files          65       65              
  Lines       12099    12103       +4     
==========================================
+ Hits        11452    11456       +4     
  Misses        647      647
Impacted Files Coverage Δ
src/subset.c 100% <100%> (ø) ⬆️
R/data.table.R 95.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb3f60...f92924b. Read the comment docs.

@mattdowle mattdowle merged commit 4757504 into master Jan 2, 2019
@mattdowle mattdowle deleted the missingij branch January 2, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

retain attributes while chaining

1 participant