Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2420 +/- ##
=========================================
+ Coverage 91.26% 91.3% +0.03%
=========================================
Files 62 62
Lines 12033 12027 -6
=========================================
- Hits 10982 10981 -1
+ Misses 1051 1046 -5
Continue to review full report at Codecov.
|
Member
|
Not sure if you know about the https://github.com/Rdatatable/data.table/pull/2420/files?w=1 |
arunsrinivasan
approved these changes
Oct 14, 2017
4 tasks
AntonNM
added a commit
to AntonNM/data.table
that referenced
this pull request
Feb 2, 2025
*Followed TODO: by mattdowle from resolution to '2-space indentation Rdatatable#2420' *Added tests for jsub that modify DT by-reference *Added test case for interger vector indexing
This was referenced Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long overdue consistent indentation.
Now that all outstanding pull requests are merged, it's a good time.
This merge touches almost every line of all C and all R files. It is strictly indentation only, no logic changes. I've eyeballed every line and am confident no dramatic sweeping mistake has taken place. The diff tools often display as if large blocks of code have changed but in fact they're just not detecting the indentation changes very well. I did lightly touch up formatting in places, in particular inside files which contained both 4-space and 2-space indentation.
I've heard it said that if a person is named by
git blameon every line, then they own the file and can re-license it! So just to be clear: that cannot be true, as this merge demonstrates. I don't own the project, all its contributors do. The license of data.table can't be changed unless all its contributors agree and this merge doesn't change that.git blameis for quickly establishing the reason for a recent breaking change.The coverage fail ("88.14% of diff hit (target 91.26%)") seems acceptable since every line is touched including the lines that are yet to be covered.