Fix tests for nested loops and labeled last#870
Open
usev6 wants to merge 1 commit intoRaku:masterfrom
Open
Conversation
As pointed out by @niner++ the old version assumed that the loops were not lazy. But as mentioned in the comment the old design docs suggested that the used syntax (having the loop inside parens) would make the loop lazy -- at least if the loop is the final statement of a statement list. This behavior is currently neither fully specced nor implemented by Rakudo. The tests weren't meant to specify the non-lazy evaluation. They only purpose was to make sure that the code doesn't crash and that the label is taken into account.
Contributor
Author
|
There is a problem when running with The Failure seems to happen, because no Seq is returned with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @niner++ the old version assumed that the loops were not lazy. But as mentioned in the comment the old design docs suggested that the used syntax (having the loop inside parens) would make the loop lazy -- at least if the loop is the final statement of a statement list.
This behavior is currently neither fully specced nor implemented by Rakudo. The tests weren't meant to specify the non-lazy evaluation. They only purpose was to make sure that the code doesn't crash and that the label is taken into account.