Conversation
calexandru2018
commented
Jun 29, 2020
calexandru2018
commented
- The CLI has been fully migrated to ArgParse
- CLI code has been written in OO paradigm
- None of the commands have been changed, fully backwards compatible with the previous version using Docopt
Have also added a custom help message.
Restored some CLI commands so that they are fully compatible with previous versions
Rafficer
left a comment
Rafficer
left a comment
There was a problem hiding this comment.
This is a great approach! Definitely going with that :)
|
docopt is still mentioned as dependency in setup.py and requirements.txt. 😜 |
Rafficer
left a comment
Rafficer
left a comment
There was a problem hiding this comment.
LGTM :)
Please let Alexandru squash-merge so it's properly counted as his contribution 👍
* Ported CLI to argparse, based on OO programming paradigm * Added descriptive comments * Updated usage string * Added logging * Updated exmaples * Removed function based CLI code * Removed docopt dependency * Added usage constant * Added back the PVPN_WAIT environment variable * Addressed Flake8 issues * Examples are now inline with the CLI * Removed unncesessary comment * Cleaned up code and improved readability * Removed dependencies still they are no longer needed * Updated inline command * Allow uppercase protocol with -p * Allign help message * Return missing -p to example Co-authored-by: Alexandru Cheltuitor <31934100+calexandru2018@users.noreply.github.com>
|
The second to last commit was force-pushed and ignored this PR which was previously merged. I was wondering if that was intentional to revert this back? Getting back to Docopt again? |
|
We are preparing the official linux CLI (currently on beta: https://protonvpn.com/blog/linux-vpn-cli-beta/). For technical reasons (as we need to prepare for smooth update from this CLI to the official one) we needed to make a small technical release as part of the planned upgrade. Unfortunately master branch already had this docopt-to-argparse branch merged in, but was too risky to make the technical release to also include this branch. |
5 participants
