Skip to content

Conversation

@NicEastvillage
Copy link
Contributor

  • Renames cars[i].config to cars[i].config_file to be in line with other fields for files
  • Renames mutator.boost to mutator.boost_amount

@VirxEC
Copy link
Collaborator

VirxEC commented Feb 21, 2025

It was always mutator.boost_amount in the match config toml so that isn't a breaking change. But a lot of people currently have their tomls setup to use config instead of config_file and after this update they will all break - could we perhaps add config as a temporary alias to config_file in the toml parsing of core? Maybe log a deprecation warning too.

@VirxEC
Copy link
Collaborator

VirxEC commented Feb 21, 2025

If that's done, the version could be v5.beta.4.3

@NicEastvillage
Copy link
Contributor Author

Sure. That is a good idea.

Copy link
Collaborator

@VirxEC VirxEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@VirxEC VirxEC merged commit 47f5d2a into master Feb 21, 2025
6 checks passed
@NicEastvillage NicEastvillage deleted the config_inconsistencies branch February 21, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants