-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Extend SubstitutePi4Rotations to 2q gates
#15483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShellyGarion
wants to merge
21
commits into
Qiskit:main
Choose a base branch
from
ShellyGarion:substitute_pi4_rotations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,228
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20696382817Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
SubstitutePi4Rotations to 2q gates SubstitutePi4Rotations to 2q gates
Collaborator
|
One or more of the following people are relevant to this code:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: New Feature
Include in the "Added" section of the changelog
fault tolerance
related to fault tolerance compilation
mod: transpiler
Issues and PRs related to Transpiler
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #15381
The
SubstitutePi4Rotationstranspiler pass now handles two types of gates:For the rotation gates, when their angle is a multiple of pi/4, they can be converted into {Clifford, T, Tdg} with a single T/Tdg gate. For even multiples, they can be written using only Clifford gates.
For the controlled-rotation gates, when their angle is a multiple of pi/2, they can be converted into {Clifford, T, Tdg} with 3 T/Tdg gates for CP and 2 T/Tdg gates otherwise. For even multiples, they can be written using only Clifford gates.
This PR also aims to reduce the total number of Clifford gates in the decompositions.
Details and comments
Note that since we should also replace 2-qubit gates (and not only 1-qubit gates), we need to construct a new DAG instead of replacing the nodes inplace.
This can make this pass slower compared to the existing code, by a factor 2x.
E.g. for a 20-qubit circuit with 10000 gates, containing a percenentage p of 1-qubit rotation gates, the total time is: