Open
Conversation
Creating a version 2 system of the current user and event schemas and models and connecting them with CRUD operations. Tests are included. The version 2 is not integrated in the system and is segregated.
Updated relevant code and tests.
yammesicka
reviewed
Mar 21, 2021
Member
yammesicka
left a comment
yammesicka
left a comment
There was a problem hiding this comment.
Awesome work!! Great code, well tested. Kudos
This constraint makes it so a user can only be added once to an event.
* Added missing test for base attributes. * Renamed get_set tests to only get_, as they don't preform any setting of values. * Fixed a bug with test_get_change_owner() * Added an additional test to test_get_add_delete_members() to check that the unique constraint works. * Added new util function.
This change better reflects the data it represents as the data is not a date object, but a complete datetime object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a version 2 system of the current user and event schemas and models and connecting them with CRUD operations.
Tests are included.
The version 2 is not integrated in the system and is segregated to allow easier implementation.