Add support for hiding walls and rooms in map rendering #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lash-L
reviewed
Feb 2, 2026
roborock/map/map_parser.py
Outdated
|
|
||
| return RoborockMapDataParser( | ||
| colors, | ||
| ColorsPalette(color_dicts if len(color_dicts) else None, room_colors if len(room_colors) else None), |
Collaborator
There was a problem hiding this comment.
Passing in a empty dict here is equivilant to passing in None. So you can just pass in color_dicts and room_colors
Collaborator
There was a problem hiding this comment.
You can ignore commit lint as i can fix when i merged, but can you fix this?
Contributor
Author
There was a problem hiding this comment.
Sorry, I have just seen your messages, ok I fix that, thank you
johnmph
force-pushed
the
feature/hide-walls-rooms-options
branch
from
94a949d to
6b276e0
Compare
Lash-L
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for hiding walls and rooms in map rendering.
Need also this commit in Home Assistant :
home-assistant/core#162053