Bunch of PureMVC improvements and bug fixings#1
Merged
tekool merged 49 commits intoPureMVC:masterfrom Oct 19, 2012
Merged
Conversation
added 30 commits
September 25, 2012 19:42
…nsumed after the first execution
added 18 commits
October 13, 2012 23:46
… fail the if statement
This reverts commit 541b972.
Member
|
I'll make a quick code review with a colleague of mine in the day. Keep you informed, but a first glimpse at what you made seems pretty needed, thank you. |
Author
|
Ok, done here https://github.com/expobrain/puremvc-python-standard-framework/commit/bb6ac2d22640796169c8c7a1574f1df7dacb3cb6, with a brand new unit test |
tekool
added a commit
that referenced
this pull request
Oct 19, 2012
Bunch of PureMVC improvements and bug fixings
Member
|
My colleague who knows Python very well validated your work and tells me that your choices were all the smart ones. |
Author
|
Thank you sir, but I did only my job :-) What about increasing the version number to 1.2.1? |
Member
|
Just make any changes you think useful, integrating changes with Github is really painless. Version number must be edited by you in the version.txt first. I'll report it in the Python port home page if Cliff is agree to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed som bugs in the implementation of some interfaces and classes and added little improvements on the code and unit tests