fix: Installation tests by pinning lm-eval extras.#585
fix: Installation tests by pinning lm-eval extras.#585ParagEkbote wants to merge 1 commit intoPrunaAI:mainfrom
Conversation
|
I'm a bit perplexed about the deps either being extras of vllm or lm-eval. Could you please let me know? cc: @johannaSommer |
|
Hi @ParagEkbote! Thanks for the quick review. We'll check asap! It should solve the failings. |
|
Closed and re-opened to re-trigger the tests :) |
|
This PR has been inactive for 10 days and is now marked as stale. |
| vllm = [ | ||
| "vllm>=0.16.0", | ||
| "ray", | ||
| "nvidia-cudnn-frontend; sys_platform == 'linux'", |
There was a problem hiding this comment.
I am a bit confused, why did we change the vllm extras, for fixing the lm-eval problem?
There was a problem hiding this comment.
Hi, as you can view in the failing jobs, there are a couple of missing deps which are not installed during the installation test, which may cause the test to fail. Attaching some images for more context:
So, I am a bit uncertain if the deps should be a part of vllm or lm-eval dependency grouping since these are cuda driver packages which are generally pulled for vllm. I'd be happy to iterate to change them for lm-eval dependency grouping.


Description
Installation tests have been failing on
maindue to missing wheels for nvidia-cutlass-dsl-libs-base and nvidia-cudnn-frontend since both of these deps publish wheels only for linux, not for MacOS and Windows. Could you please review?cc: @johannaSommer
ref:
https://github.com/PrunaAI/pruna/actions/runs/23354770495/job/67942686570
https://github.com/PrunaAI/pruna/actions/runs/23354770495/job/67942686541
Related Issue
Fixes #(issue number)
Type of Change
How Has This Been Tested?
Checklist
Additional Notes