Conversation
40584f7 to
c3715ac
Compare
c3715ac to
9e9ed1a
Compare
23a383c to
a94c2ba
Compare
simlang
left a comment
There was a problem hiding this comment.
Amazing! 🚀 next to typo and a docstring thing, just the collate_fn thing. completely up to you if you agree or not. easy approve
davidberenstein1957
left a comment
There was a problem hiding this comment.
Some small comments, feel free to merge after.
| @@ -135,6 +135,7 @@ def from_string( | |||
| collate_fn_args: dict = dict(), | |||
| dataloader_args: dict = dict(), | |||
| seed: int = 42, | |||
| category: str | list[str] | None = None, | |||
There was a problem hiding this comment.
should we mention a list of categories also somehwere in the doctstring
There was a problem hiding this comment.
I added a very simple definition of category here because there's a chance we will use this category attribute also for other datasets in the feature so we are not limited to VBench, but will be adding the categories of VBench in the documentation update how does that sound?
| @@ -25,10 +25,16 @@ invalid-assignment = "ignore" # mypy is more permissive with Any assignments | |||
| call-non-callable = "ignore" # mypy allows more dynamic method calls | |||
| index-out-of-bounds = "ignore" # mypy is more permissive with tuple indexing | |||
| unresolved-attribute = "ignore" # mypy is more permissive with module attributes | |||
| possibly-unbound-attribute = "ignore" # mypy doesn't warn about this as much | |||
| possibly-unbound-variable = "ignore" # mypy doesn't warn about this as much | |||
| redundant-cast = "ignore" # mypy doesn't warn about redundant casts | |||
There was a problem hiding this comment.
you had also applied these changes in another PR. should we add some comment in either PR about whhy and what happened?
There was a problem hiding this comment.
Yes ofcourse! Basically, we switched to ty from mypy for static type checking and it's more restrictive than mypy. Maybe, sometime in the future we will enforce all of these rules, but for now, we are restricting them to be similar to what we had with mypy! We have this as a comment in line 22 in this file but it doesn't show since it was not added by me 🥺
00b2ea7 to
4d66c4e
Compare
Bug: Incorrect Iteration in List ComprehensionThe list comprehension for |
4d66c4e to
ec46aa6
Compare
ec46aa6 to
3d21412
Compare
Description
This PR introduces the prompt suite of VBench as a pruna datamodule.
The updates in this PR:
Type of Change
How Has This Been Tested?
Added a test in our datamodule tests
Checklist
Additional Notes
You can use the new datamodule as follows:
Note
Adds VBench prompt suite as a dataset, introduces
prompt_with_auxiliaries_collate, enables category filtering viaPrunaDataModule.from_string, and integrates tests.text_to_video.setup_vbench_datasetto load VBench prompts fromVBench_full_info.json, rename columns tocategoryandtext, optionalcategoryfiltering, and return test-focused splits."VBench"inbase_datasetsusingprompt_with_auxiliaries_collate.prompt_with_auxiliaries_collatereturningList[str]prompts and auxiliary metadata dicts; expose viapruna_collate_fns.from_stringwithcategoryarg; auto-forward to setup functions that accept it.VBenchtotest_dm_from_stringmatrix.Written by Cursor Bugbot for commit 3d21412. This will update automatically on new commits. Configure here.