feat: allow loading models without a smash config#340
Merged
Conversation
gsprochette
requested changes
Sep 10, 2025
Collaborator
gsprochette
left a comment
There was a problem hiding this comment.
Looks good, a single iteration should do it :)
- I would recommend renaming the PR to something in the line of
feat: allow loading models without a smash config. - If we decide to add a device_map argument in the loading functions, that can be done in an other PR
gsprochette
reviewed
Sep 11, 2025
gsprochette
reviewed
Sep 11, 2025
gsprochette
approved these changes
Sep 12, 2025
Collaborator
gsprochette
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing all the changes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables to load any diffusers and transformers models even if they do not have smash configs. This is useful for benchmarking of all models regardless if they are wrapped or not with Pruna.
Related Issue
Fixes #(issue number)
Type of Change
How Has This Been Tested?
Checklist
Additional Notes