docs: add target modules documentation#331
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
minettekaum
left a comment
There was a problem hiding this comment.
Found some small fixes in the notebook but otherwise looks good :)
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
I also went through all 1-5 titles and made every noun start with a capital letter, previously that was inconsistent
sdiazlor
left a comment
There was a problem hiding this comment.
LGTM! I added just some tiny comments to improve the readability :)
65f4cb6 to
1e3e557
Compare
sharpenb
left a comment
There was a problem hiding this comment.
I left some quick comments. That is very nice. I kind of see the point of having cells outputs for tutorials since it amkes notebooks more attractive. As discussed, this can be addressed in another PR to introduce it on all tutorials :)
docs/tutorials/index.rst
Outdated
There was a problem hiding this comment.
Can we find a more catchy name here e.g. "Compressing at Finer Granularity with Target Modules"? :)
There was a problem hiding this comment.
I went with "Smashing at Finer Granularity with Target Modules", is that ok for you?
docs/user_manual/target_modules.rst
Outdated
There was a problem hiding this comment.
See the other comment to use a more catchy name ;) This is the technical name byt the tile should explain the value for the users :)
There was a problem hiding this comment.
I went with "Selective Smashing with Target Modules"
8315063 to
52b6dab
Compare
52b6dab to
0c368b4
Compare
Description
Add documentation for target modules:
Related Issue
Fixes #(issue number)
Type of Change
How Has This Been Tested?
Building the documentation
Checklist
Additional Notes
I think an other documentation page about how to use the
map_targeted_nn_rootsfunction would have its place somewhere in the "Customize components" section, but this is left for an other PR