Skip to content

tests: update fixtures for algorithm and evaluation tests#288

Merged
johannaSommer merged 8 commits intomainfrom
tests/fixtures-update
Aug 7, 2025
Merged

tests: update fixtures for algorithm and evaluation tests#288
johannaSommer merged 8 commits intomainfrom
tests/fixtures-update

Conversation

@johannaSommer
Copy link
Copy Markdown
Member

Description

In this PR, we update the test setup in several ways:

  • tiny fixtures: where not already the case, we replace fixture references to "large models" like opt125m with their tiny variants
  • outdated fixtures: where possible, we make flux the default fixture for testing
  • unused fixtures: since switching to the tiny models for testing, we have a few unused fixtures that I have removed

Related Issue

None.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran tests via the nightlies.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

None.

cursor[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Member

@johnrachwan123 johnrachwan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"""
# INFO should be suppressed also for inference --> we set the level to WARNING not just temporarily
logging.getLogger().setLevel(logging.WARNING)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Compiler Alters Global Logging, Suppresses Important Messages

The StableFastCompiler permanently sets the global root logger level to WARNING. This modifies the application's global logging state, suppressing important log messages from other parts of the system throughout its lifetime, rather than temporarily for the compilation operation.

Fix in Cursor Fix in Web

@johannaSommer johannaSommer merged commit 5b09957 into main Aug 7, 2025
7 checks passed
@johannaSommer johannaSommer deleted the tests/fixtures-update branch August 7, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants