Skip to content

fix: pin torchmetric until PSNR adjustment#274

Merged
johannaSommer merged 1 commit intomainfrom
fix/torchmetrics-dependency
Jul 24, 2025
Merged

fix: pin torchmetric until PSNR adjustment#274
johannaSommer merged 1 commit intomainfrom
fix/torchmetrics-dependency

Conversation

@johannaSommer
Copy link
Copy Markdown
Member

Description

After the release of torchmetrics 1.8.0 PSNR needs an additional data_range argument that needs to be implemented before upgrading to the latest version.

Related Issue

Fixes #(issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@simlang simlang self-requested a review July 24, 2025 08:34
Copy link
Copy Markdown
Member

@simlang simlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! quick "fix" for now, but should be addressed soon 👍

@johannaSommer johannaSommer merged commit e2c1cec into main Jul 24, 2025
6 checks passed
@johannaSommer johannaSommer deleted the fix/torchmetrics-dependency branch July 24, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants