Merged
Conversation
2ece04b to
52d2dc8
Compare
sharpenb
reviewed
Jul 20, 2025
Member
sharpenb
left a comment
There was a problem hiding this comment.
Very cool new metric! This is close to merge. Beyond my comments, a last thing would be to have/extend a tutorial with these introduced metric (it can be in another PR). This tutorial could take an image compute the metrics on it, and then perturb it it (e.g. by adding blur or other things mentioned in this paper). The goal would be to justify the relevance of these metrics :)
davidberenstein1957
approved these changes
Jul 22, 2025
sdiazlor
approved these changes
Jul 22, 2025
* Introduced `SharpnessMetric` for evaluating image sharpness using Laplacian variance. * Added tests for `SharpnessMetric` to validate its functionality across different models and configurations. * Included `opencv-python` as a new dependency in `pyproject.toml` to support sharpness calculations.
…cessing - Added detailed descriptions of the sharpness metric calculation and its parameters. - Clarified that sharpness is computed on the grayscale version of images. - Improved comments in the code for better understanding of image processing steps.
2db8584 to
9ea0944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds SharpnessMetric, which computes focus via the variance of the Laplacian (higher = sharper).
CPU‑side numpy/OpenCV implementation.
Type of Change
Checklist
Additional Notes
You can use the
SharpnessMetricdirectly or via the EvaluationAgent: