Skip to content

feat: clipiqa metric#259

Merged
johannaSommer merged 2 commits intomainfrom
feat/clipiqa
Jul 23, 2025
Merged

feat: clipiqa metric#259
johannaSommer merged 2 commits intomainfrom
feat/clipiqa

Conversation

@begumcig
Copy link
Copy Markdown
Member

@begumcig begumcig commented Jul 16, 2025

Description

This PR integrates the CLIP-IQA metric from torchmetrics.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@begumcig begumcig requested a review from sharpenb July 16, 2025 13:36
sharpenb
sharpenb approved these changes Jul 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sharpenb sharpenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the metric, this is just cool!

@davidberenstein1957
feat: add CLIP Image Quality Assessment metric and update dependencies
a681d02 
* Introduced `CLIPImageQualityAssessment` to the TorchMetrics enumeration.
* Updated `MetricResult` to support results as a list for IQA metrics.
* Added a new test for the `clipiqa` metric to validate its functionality.
* Included `piq` as a dependency in `pyproject.toml`.
@davidberenstein1957
fix: update pairwise metric handling in tests
6f9fee5 
* Modified the test for `TorchMetricWrapper` to include `clipiqa` alongside `arniqa` for pairwise call types.
* Adjusted assertions to ensure correct call type behavior for both metrics.
@davidberenstein1957 davidberenstein1957 self-requested a review July 22, 2025 12:19
@johannaSommer johannaSommer merged commit ffd907a into main Jul 23, 2025
9 checks passed
@johannaSommer johannaSommer deleted the feat/clipiqa branch July 23, 2025 15:16
@davidberenstein1957 davidberenstein1957 added documentation Improvements or additions to documentation metric and removed documentation Improvements or additions to documentation labels Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharpenb sharpenb sharpenb approved these changes

@davidberenstein1957 davidberenstein1957 davidberenstein1957 approved these changes

@sdiazlor sdiazlor sdiazlor approved these changes

Assignees

No one assigned

Labels

metric

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@begumcig @sharpenb @davidberenstein1957 @sdiazlor @johannaSommer