fix: device state of input model for memory metrics#256
Merged
johannaSommer merged 1 commit intomainfrom Jul 14, 2025
Merged
Conversation
begumcig
approved these changes
Jul 14, 2025
Member
begumcig
left a comment
There was a problem hiding this comment.
Hihi I also added these in the multiGPU PR but already merging it makes so much sense for the nightlies and releases tysmmmm ❤️❤️. Looks super good to me!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes failures in the
memory_metrictests as the input model is on CPU, which is not allowed for this metric.Related Issue
None.
Type of Change
How Has This Been Tested?
Reran failing tests locally.
Checklist
Additional Notes
None.