Skip to content

fix: device state of input model for memory metrics#256

Merged
johannaSommer merged 1 commit intomainfrom
fix/memory-test-setup
Jul 14, 2025
Merged

fix: device state of input model for memory metrics#256
johannaSommer merged 1 commit intomainfrom
fix/memory-test-setup

Conversation

@johannaSommer
Copy link
Copy Markdown
Member

Description

This PR fixes failures in the memory_metric tests as the input model is on CPU, which is not allowed for this metric.

Related Issue

None.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Reran failing tests locally.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

None.

@johannaSommer johannaSommer requested a review from begumcig July 14, 2025 07:30
Copy link
Copy Markdown
Member

@begumcig begumcig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hihi I also added these in the multiGPU PR but already merging it makes so much sense for the nightlies and releases tysmmmm ❤️❤️. Looks super good to me!!

@johannaSommer johannaSommer merged commit 4384157 into main Jul 14, 2025
6 checks passed
@johannaSommer johannaSommer deleted the fix/memory-test-setup branch July 14, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants