Skip to content

fix: change janus import into automodel import#243

Merged
johannaSommer merged 3 commits intomainfrom
fix/change_janus_to_automodel
Jul 11, 2025
Merged

fix: change janus import into automodel import#243
johannaSommer merged 3 commits intomainfrom
fix/change_janus_to_automodel

Conversation

@llcnt
Copy link
Copy Markdown
Collaborator

@llcnt llcnt commented Jul 9, 2025

Description

This PR makes use and replace the JanusForConditionalGeneration by a AutoModelForImageTextToText : in case there is a package version mismatch, only the Janus test would fail with some model-not-available-error.

Related Issue

The previous PR #145 on janus introduced some test that yields import error if the transformers is outdated.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Local test on Janus pass

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@llcnt llcnt marked this pull request as ready for review July 9, 2025 15:51
@llcnt llcnt requested a review from johannaSommer July 9, 2025 16:30
@johannaSommer johannaSommer merged commit 91e36a7 into main Jul 11, 2025
6 checks passed
@johannaSommer johannaSommer deleted the fix/change_janus_to_automodel branch July 11, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants