Skip to content

build: fix MacOS installation issues with bnb and uv index resolution#235

Merged
johannaSommer merged 2 commits intomainfrom
fix/bnb-macos-installation
Jul 8, 2025
Merged

build: fix MacOS installation issues with bnb and uv index resolution#235
johannaSommer merged 2 commits intomainfrom
fix/bnb-macos-installation

Conversation

@johannaSommer
Copy link
Copy Markdown
Member

@johannaSommer johannaSommer commented Jul 8, 2025

Description

This PR fixes:

  • missing system specification for the bits and bytes packages
  • the installation configuration for the GitHub actions, causing too many pings on the pruna pythonanywhere

Related Issue

None.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Installation tests pass now, so do mypy tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

None.

@johannaSommer johannaSommer marked this pull request as ready for review July 8, 2025 12:36
@johannaSommer johannaSommer changed the title build: fix MacOS installation issues with bnb build: fix MacOS installation issues with bnb and uv index resolution Jul 8, 2025
@johannaSommer johannaSommer force-pushed the fix/bnb-macos-installation branch 3 times, most recently from 8a0e19c to 108ad4b Compare July 8, 2025 13:59
@johannaSommer johannaSommer force-pushed the fix/bnb-macos-installation branch from 49ef83d to 9c9b56f Compare July 8, 2025 14:16
@johannaSommer johannaSommer force-pushed the fix/bnb-macos-installation branch from 9c9b56f to b001649 Compare July 8, 2025 14:46
Copy link
Copy Markdown
Member

@johnrachwan123 johnrachwan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks a lot for the hard work!

@johannaSommer johannaSommer merged commit 12cf15f into main Jul 8, 2025
18 of 19 checks passed
@johannaSommer johannaSommer deleted the fix/bnb-macos-installation branch July 8, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants