Skip to content

feat: extend accelerate compatibility#234

Merged
johannaSommer merged 3 commits intomainfrom
feat/extend-accelerate-compatibility
Jul 9, 2025
Merged

feat: extend accelerate compatibility#234
johannaSommer merged 3 commits intomainfrom
feat/extend-accelerate-compatibility

Conversation

@johannaSommer
Copy link
Copy Markdown
Member

Description

This PR unlocks several algorithms for base models that are distributed with accelerate.

Related Issue

None.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Enabling accelerate automatically unlocks accelerate algorithm tests, which all pass locally.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

None.

Copy link
Copy Markdown
Member

@johnrachwan123 johnrachwan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@llcnt llcnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!
Small question(s): what makes these algo compatible with multi-gpus (did you have to adapt something in the code earlier, or they are compatible by nature?) ? What makes other algo (eg gptq) not compatible with multi-gpus ?

@johannaSommer johannaSommer merged commit 050fb51 into main Jul 9, 2025
6 of 7 checks passed
@johannaSommer johannaSommer deleted the feat/extend-accelerate-compatibility branch July 9, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants