test: add pytest and code coverage configuration in pyproject.toml#230
Conversation
johannaSommer
left a comment
There was a problem hiding this comment.
Looks already good to me! I have just one quick question on the markers :)
pyproject.toml
Outdated
| "src/pruna/tests", | ||
| ] | ||
|
|
||
| markers = [ |
There was a problem hiding this comment.
In this case could we remove the markers from the conftest.py?
There was a problem hiding this comment.
No, the markers need to be present in conftest.py that provide reusable setup/teardown logic for tests. We have defined the markers here to maintain a reference of all the markers available. We could remove them if needed.
There was a problem hiding this comment.
@ParagEkbote, should we remove markers from here? It would be difficult to maintain them in two different places.
There was a problem hiding this comment.
It makes sense. @davidberenstein1957
I've removed them. Could you please review?
|
@ParagEkbote thanks again for the lovely PR! They are really welcome :) |
Description
As described in the issue, I have added the pytest configuration as well the code coverage configuration to get better output and verbosity when the tests are executed.
Could you please review?
cc: @johannaSommer
Related Issue
Fixes #228
Type of Change
How Has This Been Tested?
Checklist