Skip to content

fix: device of FID torch metric#223

Merged
johannaSommer merged 1 commit intomainfrom
fix/evaluation-agent-test
Jun 30, 2025
Merged

fix: device of FID torch metric#223
johannaSommer merged 1 commit intomainfrom
fix/evaluation-agent-test

Conversation

@johannaSommer
Copy link
Copy Markdown
Member

Description

This PR fixes the torch_metrics test for FID, which fails currently as the metric (when the tests run on CPU) is cast to CUDA but the inputs are on CPU.

Related Issue

Fixes #(issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@johannaSommer johannaSommer requested a review from begumcig June 30, 2025 12:51
Copy link
Copy Markdown
Member

@begumcig begumcig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSuperGTMeee!! Thanks a lot!!

@johannaSommer johannaSommer merged commit 8748ff6 into main Jun 30, 2025
6 of 7 checks passed
@johannaSommer johannaSommer deleted the fix/evaluation-agent-test branch June 30, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants