Skip to content

feature: Refactor CI to use shared setup-uv-project action #211

Merged
johannaSommer merged 4 commits intoPrunaAI:mainfrom
GreatBahram:feature-refactor-uv-setup
Jul 8, 2025
Merged

feature: Refactor CI to use shared setup-uv-project action #211
johannaSommer merged 4 commits intoPrunaAI:mainfrom
GreatBahram:feature-refactor-uv-setup

Conversation

@GreatBahram
Copy link
Copy Markdown
Contributor

@GreatBahram GreatBahram commented Jun 23, 2025

Description

This PR introduces a reusable composite GitHub Action to standardize uv setup across workflows.

Related Issue

Fixes #(issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@GreatBahram GreatBahram mentioned this pull request Jun 23, 2025
10 tasks
runs:
using: composite
steps:
- uses: astral-sh/setup-uv@v6
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv setups live here, and I've activated the virtual environment by default, so we don't need to prefix commands with uv.

@GreatBahram
Copy link
Copy Markdown
Contributor Author

@johannaSommer
Copy link
Copy Markdown
Member

Hey @GreatBahram we really appreciate the contribution! Sorry for the late response, the Pruna team was offsite for our team retreat, but now we are back in action and will have a look ASAP.

Copy link
Copy Markdown
Member

@johannaSommer johannaSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already perfect to me, really cool change it makes things a lot cleaner and less redundant!

Copy link
Copy Markdown
Member

@johnrachwan123 johnrachwan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you rebase on to main to resolve the changes and then we merge ?

@GreatBahram GreatBahram force-pushed the feature-refactor-uv-setup branch from 40e7f04 to 698fdd9 Compare July 3, 2025 05:59
@GreatBahram
Copy link
Copy Markdown
Contributor Author

LGTM! Can you rebase on to main to resolve the changes and then we merge ?

Thanks, @johnrachwan123! Rebased the main branch into this; feel free to merge this 🚀

@johannaSommer johannaSommer merged commit 7be6b73 into PrunaAI:main Jul 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants