Skip to content

test: connect inference/eval tests to algorithms#181

Merged
begumcig merged 6 commits intomainfrom
test/evaluation-tester
Aug 1, 2025
Merged

test: connect inference/eval tests to algorithms#181
begumcig merged 6 commits intomainfrom
test/evaluation-tester

Conversation

@begumcig
Copy link
Copy Markdown
Member

@begumcig begumcig commented Jun 6, 2025

Description

Adding simple evaluation runs to the algorithm tests to check if model is capable of running inference, and the inference outputs are compatible with the evaluation agent.
Small bug fixes here and there to get the tests up and running

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@begumcig begumcig force-pushed the test/evaluation-tester branch 5 times, most recently from d177d4f to 534e48b Compare June 6, 2025 16:23
@begumcig begumcig marked this pull request as ready for review June 6, 2025 16:36
Copy link
Copy Markdown
Member

@johannaSommer johannaSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant believe you did this and its almost flawless on the first take, i really appreciate the effort you put into this, it's so key! just a bit of comments and logic changes then we're already GTG

Comment thread src/pruna/engine/handler/handler_utils.py Outdated
Comment thread src/pruna/engine/utils.py Outdated
Comment thread src/pruna/evaluation/metrics/metric_pairwise_clip.py Outdated
Comment thread tests/algorithms/testers/compilation.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nifleisch @johnrachwan123 if we require the fullgraph this often, should we consider making this the new default?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. fullgraph=False is also the default torch.compile uses so it would be more convenient to match this default. Especially since fullgraph=True can lead to graph breaks for certain models and is less stable.

Comment thread tests/common.py Outdated
@begumcig begumcig force-pushed the test/evaluation-tester branch from 534e48b to f991924 Compare July 9, 2025 13:10
@begumcig begumcig force-pushed the test/evaluation-tester branch from feb2379 to 0064b4f Compare July 10, 2025 16:47
Copy link
Copy Markdown
Member

@johannaSommer johannaSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚔

Copy link
Copy Markdown
Collaborator

@nifleisch nifleisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the PR, approved! 🙌

Comment thread tests/algorithms/testers/compilation.py Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. fullgraph=False is also the default torch.compile uses so it would be more convenient to match this default. Especially since fullgraph=True can lead to graph breaks for certain models and is less stable.

@begumcig begumcig force-pushed the test/evaluation-tester branch from 52ac709 to bd53d1c Compare July 30, 2025 13:09
@begumcig begumcig force-pushed the test/evaluation-tester branch from bd53d1c to c5ee1a9 Compare July 30, 2025 13:17
@begumcig begumcig force-pushed the test/evaluation-tester branch from 1d679b9 to c2db893 Compare July 30, 2025 13:55
@begumcig begumcig force-pushed the test/evaluation-tester branch from b5eb3de to 9530ab9 Compare July 30, 2025 20:02
@begumcig begumcig force-pushed the test/evaluation-tester branch from 8c8d10c to 5eca98d Compare July 31, 2025 12:57
Copy link
Copy Markdown
Member

@johannaSommer johannaSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🫡

@begumcig begumcig merged commit b311016 into main Aug 1, 2025
6 checks passed
@begumcig begumcig deleted the test/evaluation-tester branch August 1, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants