chore: update pyproject.toml for optional dependencies and bitsandbytes#175
Merged
davidberenstein1957 merged 4 commits intomainfrom Jun 6, 2025
Conversation
…ncies - Added `poetry.lock` to manage package dependencies and versions. - Updated `pyproject.toml` to conditionally include `bitsandbytes` based on platform compatibility. - Refined optional dependencies for development and testing, ensuring proper markers for each package.
- Added `gptqmodel` version 2.2.0 to `poetry.lock` with optional dependencies for various functionalities. - Updated `pyproject.toml` to conditionally include `gptqmodel` based on platform compatibility, ensuring proper handling for different environments. - Refined optional dependencies for `gptqmodel`, enhancing support for additional features and tools.
- Added a comment in `pyproject.toml` indicating that `gptqmodel` version 4.0.0.dev0+cu126torch2.7 is not supported on macOS arm64, enhancing clarity for developers regarding platform compatibility.
SaboniAmine
approved these changes
Jun 5, 2025
Member
SaboniAmine
left a comment
SaboniAmine
left a comment
There was a problem hiding this comment.
Thanks! The optional bnb install seems great, however not sure about the lock file. As we're migrating to uv, I'd rather share a lockfile using uv's constraints management (poetry can be slow to compute constraints).
davidberenstein1957
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gtregoat
approved these changes
Jun 6, 2025
Member
gtregoat
left a comment
gtregoat
left a comment
There was a problem hiding this comment.
LGTM! Was able to install with uv!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poetry.lockto manage package dependencies and versions.pyproject.tomlto conditionally includebitsandbytesbased on platform compatibility.Description
Related Issue
Fixes #149
Type of Change
How Has This Been Tested?
Checklist
Additional Notes