Skip to content

fix: fix fp8dqrow setting#156

Merged
nifleisch merged 1 commit intomainfrom
fix/fix-torchao-fp8dqrow
Jun 18, 2025
Merged

fix: fix fp8dqrow setting#156
nifleisch merged 1 commit intomainfrom
fix/fix-torchao-fp8dqrow

Conversation

@nifleisch
Copy link
Copy Markdown
Collaborator

@nifleisch nifleisch commented May 28, 2025

Description

The quant type "fp8dqrow" was not working. This fix makes this option work for GPUs with CUDA Compute Capability >= 8.9 (e.g., L40S, H100).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run the algorithms with quant type "fp8dqrow" and "int8dq". Tested the combination with torch.compile and without it.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nifleisch nifleisch requested review from johnrachwan123 and llcnt May 28, 2025 15:46
Copy link
Copy Markdown
Member

@johnrachwan123 johnrachwan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add which GPUs are supported in the PR description please ?

Copy link
Copy Markdown
Collaborator

@llcnt llcnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thx :)

@nifleisch nifleisch merged commit 4fd773e into main Jun 18, 2025
8 checks passed
@nifleisch nifleisch deleted the fix/fix-torchao-fp8dqrow branch June 18, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants