Skip to content

feat: streamline import failure handling#152

Merged
johannaSommer merged 10 commits intomainfrom
feat/import-handling
Jun 11, 2025
Merged

feat: streamline import failure handling#152
johannaSommer merged 10 commits intomainfrom
feat/import-handling

Conversation

@johannaSommer
Copy link
Copy Markdown
Member

Description

This PR extends the algorithm base class to wrap any import_algorithm_packages definition as soon as a subclass is instantiated. It then provides a streamlined error with an informative message, if possible, referencing the documented installation.

Related Issue

None.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Verified locally that the function is wrapped and provides the appropriate error message.

Checklist

  • [ x My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

None.

@johannaSommer johannaSommer force-pushed the feat/import-handling branch from 8beaf25 to c1f769a Compare May 28, 2025 14:41
Copy link
Copy Markdown
Collaborator

@llcnt llcnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo nice to get rid of these "try... except", thank you !! :)

Copy link
Copy Markdown
Member

@johnrachwan123 johnrachwan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise looks good

@johannaSommer johannaSommer merged commit 5ae797b into main Jun 11, 2025
6 checks passed
@johannaSommer johannaSommer deleted the feat/import-handling branch June 11, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants