Skip to content

feat: add llm_compressor quantizer#144

Merged
johnrachwan123 merged 5 commits intomainfrom
codex/integrate-llm-compressor-quantizer-into-pruna
May 27, 2025
Merged

feat: add llm_compressor quantizer#144
johnrachwan123 merged 5 commits intomainfrom
codex/integrate-llm-compressor-quantizer-into-pruna

Conversation

@johnrachwan123
Copy link
Copy Markdown
Member

@johnrachwan123 johnrachwan123 commented May 21, 2025 •
edited
Loading

Description

  • integrate llmcompressor quantizer
  • test integration for llmcompressor
  • depend on llmcompressor

Related Issue

None.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

None.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

We can extend this PR to also add other functionalities from llm-compressor.

@llcnt llcnt mentioned this pull request May 21, 2025
Merged
10 tasks
@johnrachwan123 johnrachwan123 changed the title Add llm_compressor quantizer feat: add llm_compressor quantizer May 22, 2025
@johnrachwan123 johnrachwan123 marked this pull request as ready for review May 26, 2025 14:11
johannaSommer
johannaSommer requested changes May 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@johannaSommer johannaSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there - please also fix the code quality issues

src/pruna/algorithms/quantization/llm_compressor.py Outdated
Copy link
Copy Markdown
Member

@johannaSommer johannaSommer May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format docstring according to other methods - second paragraph will be rendered in the documentation

johannaSommer
johannaSommer reviewed May 26, 2025
View reviewed changes
@johnrachwan123 johnrachwan123 force-pushed the codex/integrate-llm-compressor-quantizer-into-pruna branch from 47755e4 to 7a7f19d Compare May 27, 2025 09:36
johannaSommer
johannaSommer approved these changes May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@johannaSommer johannaSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please fix the Code Quality checks before merging.

@johnrachwan123 johnrachwan123 merged commit c5130f0 into main May 27, 2025
6 checks passed
@johnrachwan123 johnrachwan123 deleted the codex/integrate-llm-compressor-quantizer-into-pruna branch May 27, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johannaSommer johannaSommer johannaSommer approved these changes

@llcnt llcnt Awaiting requested review from llcnt

Assignees

No one assigned

Labels

algorithm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnrachwan123 @johannaSommer @davidberenstein1957