Conversation
DolphaGo
approved these changes
Dec 21, 2021
Member
|
inline method 신기하네 ^^ |
unluckyjung
reviewed
Dec 23, 2021
| val errorCode = lazyErrorCode() | ||
| throw ApiException(errorCode) | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
정말 별거 아니면서 별거인 No newline at end of file 은 가능하면 처리해두시는게 좋습니다.
이 파일외에도 꽤 많이보이네요.
merge 과정에서 문제가 생길수 있는 여지가 존재합니다.
Contributor
There was a problem hiding this comment.
여기 코멘트에서는 표시가 안되는데, PR의 Files Changed로 가서 보시면 확인가능합니다.
ParkJiwoon
added a commit
that referenced
this pull request
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kotlin 에서 기본적으로 제공하는
check,checkNotNull은IllegalStateException을 반환함우리는 에러 형식을 Enum 클래스로 정의하여 사용하고 있기 때문에 이에 맞춘 별도의
check메소드가 필요