Skip to content

Assign distinct reform IDs to national tax expenditure targets#657

Open
MaxGhenis wants to merge 2 commits intomainfrom
codex/jct-reform-ids
Open

Assign distinct reform IDs to national tax expenditure targets#657
MaxGhenis wants to merge 2 commits intomainfrom
codex/jct-reform-ids

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

Summary

  • assign distinct reform_id values to each national JCT tax expenditure target instead of reusing a single generic reform id
  • store those ids directly on the target rows so the reform identity stays stable even if a target variable name changes later
  • add a database-build regression test covering the distinct reform ids

Testing

  • python3 -m py_compile policyengine_us_data/db/etl_national_targets.py policyengine_us_data/tests/test_database_build.py
  • ruff check policyengine_us_data/db/etl_national_targets.py policyengine_us_data/tests/test_database_build.py
  • PYTHONPATH=/Users/maxghenis/.codex-worktrees/jct-reform-ids /Users/maxghenis/.codex-worktrees/policyengine-us-data-mid/.venv/bin/python -m pytest policyengine_us_data/tests/test_database_build.py -k 'national_targets_loaded or distinct_reform_ids' -q

@MaxGhenis MaxGhenis enabled auto-merge March 28, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant