Clean up reform validation cache and add regression tests#651
Open
Clean up reform validation cache and add regression tests#651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged PR #639.
This cleanup PR addresses a few non-blocking review items from the JCT/SOI target fix:
income_taxdelta, rather than briefly caching raw reform values and then overwriting them in the callervalidate_staging.pyWhy
PR #639 fixed the economics and the calibration path. This PR just tightens the maintenance story around that fix and adds regression coverage for two of the follow-up risks reviewers flagged.
Validation
python3 -m py_compile policyengine_us_data/calibration/validate_staging.py policyengine_us_data/tests/test_calibration/test_validate_staging.py policyengine_us_data/tests/test_etl_national_targets.pyruff formaton the touched filesEnvironment limitation
I did not run the full pytest path locally in this workspace because the available local environments are still broken on
torch/ missingsqlmodel.