Skip to content

Fix bug in intra-decile chart #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhilwoodruff merged 1 commit into from
Dec 28, 2022
Merged

Fix bug in intra-decile chart #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog_entry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- bump: patch
changes:
fixed:
- Negative income handling in the intra-decile chart.
9 changes: 7 additions & 2 deletions policyengine_api/compute_api/compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,14 @@ def intra_decile_impact(baseline: dict, reform: dict) -> dict:
baseline["household_count_people"], weights=baseline_income.weights
)
decile = MicroSeries(baseline["household_income_decile"]).values
income_change = (
np.maximum(reform_income, 1) / np.maximum(baseline_income, 1) - 1
absolute_change = (reform_income - baseline_income).values
capped_baseline_income = np.maximum(baseline_income.values, 1)
capped_reform_income = (
np.maximum(reform_income.values, 1) + absolute_change
)
income_change = (
capped_reform_income - capped_baseline_income
) / capped_baseline_income

# Within each decile, calculate the percentage of people who:
# 1. Gained more than 5% of their income
Expand Down