Skip to content

Games/Hearthstone : Update, fixes #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kreyren wants to merge 2 commits into from
Closed

Games/Hearthstone : Update, fixes #793

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4695a93
Games/Hearthstone : Update, fixes
Jan 9, 2019
040805b
Update script.js
Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Applications/Games/Hearthstone/Online/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,24 @@
include(["engines", "wine", "quick_script", "online_installer_script"]);
include(["engines", "wine", "plugins", "windows_version"]);
include(["engines", "wine", "verbs", "vcrun2015"]);
include(["engines", "wine", "verbs", "corefonts"]);

// BUG: https://github.com/PhoenicisOrg/scripts/issues/792

// TODO: OSX support, needs verification
Copy link
Copy Markdown
Member

@qparis qparis Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add these kind of comments on the code

Copy link
Copy Markdown
Contributor

@Zemogiter Zemogiter Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found similar kind of comment in the Europa Universalis 2 script.

Copy link
Copy Markdown
Contributor

@ImperatorS79 ImperatorS79 Jan 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think I will just add a link to the website where the patches can be downloaded in a wizard ^^.

Copy link
Copy Markdown
Contributor

@Zemogiter Zemogiter Jan 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No there is a website with static links to those patches but I do not own that game. Anyway the reason I've pointed that out was because I was wondering if the comments in that script should also be removed.
https://gamefront.online/files2/listing/pub2/europa-universalis-ii/Official_Patches/?

Copy link
Copy Markdown
Contributor Author

@Kreyren Kreyren Jan 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using comments in installers seems sane assuming they are in testing. -> Helps with script development.

I would agree with not using them in non-testing scripts.

EDIT: probably some coding standarts alike every script has to work on platinum, has MACOS + LINUX support, etc.. to be qualified for non-testing


var installerImplementation = {
run: function () {
new OnlineInstallerScript()
.name("Hearthstone")
.editor("Blizzard")
.applicationHomepage("https://eu.battle.net/hearthstone/")
.author("ImperatorS79")
.author("ImperatorS79, kreyren")
.url("https://eu.battle.net/download/getInstaller?os=win&installer=Hearthstone-Setup.exe")
.category("Games")
.executable("Hearthstone.exe")
.executable("Battle.net.exe")
.wineVersion(LATEST_STAGING_VERSION)
.wineDistribution("staging")
.preInstall(function (wine/*, wizard*/) {
wine.windowsVersion("winxp");
wine.vcrun2015();
wine.corefonts();
})
Expand Down