Multiple reverse proxy support#484
Closed
b10m wants to merge 3 commits intoPerlDancer:masterfrom
b10m:master
Closed
Multiple reverse proxy support#484b10m wants to merge 3 commits intoPerlDancer:masterfrom b10m:master
b10m wants to merge 3 commits intoPerlDancer:masterfrom
b10m:master
Conversation
Apache for one allows the X-Forwarded-Host to be a comma seperated list rather than a single value. See: http://httpd.apache.org/docs/2.2/mod/mod_proxy.html#x-headers
When HTTP_REFERER is not set (which is a quite likely scenario), dancer
would die with:
isa check for "referer" failed: undef is not a string!
This forces request->referer to return an empty string, rather than
undef (which is not a Str).
Member
|
Why was this closed? |
Contributor
Author
|
Restructuring commits. See #503 for the same new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache for one allows the X-Forwarded-Host to be a comma seperated
list rather than a single value. See:
http://httpd.apache.org/docs/2.2/mod/mod_proxy.html#x-headers
In a case of:
[interwebs] -> [external proxy] -> [internal proxy] -> [Dancer]
The X-Forward-Host will look like "domain.example, domain.example". This will then be used in, e.g. redirects:
Location: http://domain.example, domain.example/redirected_page