Use the first two octets of ip addresses in fingerprint()#69
Merged
Conversation
Klakurka
approved these changes
May 29, 2025
Member
Klakurka
left a comment
There was a problem hiding this comment.
We can try this but much of the time they'll be getting a new ip address that's totally different which tells obviously doesn't address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users on dynamic IPs are being logged out each time their public address changes (e.g. home ISPs, cellular, or rotating VPN endpoints). This PR relaxes our fingerprint check in
PayButton_State::fingerprint()so that, instead of using the full client IP, we only use the first two octets for IPv4 (e.g. 203.0) or the first two hextets for IPv6 (e.g. 2001:0db8). This will help solve the frequent logout issue and will help the plugin remember a logged-in user's session for a week. I have fully tested this new feature for IPV4.Test plan: